DataGrid: fix Tab press handler in filter range (T1312521)#32199
Merged
anna-shakhova merged 4 commits intoDevExpress:26_1from Jan 20, 2026
Merged
DataGrid: fix Tab press handler in filter range (T1312521)#32199anna-shakhova merged 4 commits intoDevExpress:26_1from
anna-shakhova merged 4 commits intoDevExpress:26_1from
Conversation
anna-shakhova
force-pushed
the
26_1__T1312521
branch
3 times, most recently
from
4dc7c60 to
a2e2895
Compare
anna-shakhova
changed the title
anna-shakhova
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the DataGrid filter row code by removing unnecessary/redundant code and improving type safety and test organization.
Changes:
- Refactored filter range overlay container positioning to be relative to grid headers instead of viewport
- Improved Tab key navigation logic to handle the last column edge case
- Enhanced type safety by adding MenuInternal type import and removing TypeScript error suppressions
- Reorganized TestCafe tests by separating visual and functional tests into dedicated files
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/filterRow.tests.js |
Added helper function getFilterRowOverlay() to simplify test assertions and updated all overlay selector references |
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts |
Changed overlay container from viewport to grid element, improved Tab navigation to handle last column, added MenuInternal type, removed unnecessary blur trigger |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/visual.ts |
New file containing visual/screenshot tests previously in functional.ts |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts |
Removed visual tests (moved to visual.ts), cleaned up imports, reorganized test order |
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/T1163100_changeFIlterIcon.visual_matrix.ts |
New test file for T1163100 filter icon change visual tests |
packages/devextreme/js/__internal/grids/grid_core/filter/m_filter_row.ts
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/filterRow.tests.js
Show resolved
Hide resolved
anna-shakhova
force-pushed
the
26_1__T1312521
branch
from
a2e2895 to
b023fac
Compare
Alyar666
requested changes
Jan 19, 2026
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts:170
- The test uses
test.onlywhich will cause other tests in this file to be skipped during test execution. This should be changed totestbefore merging to ensure all tests run in CI.
e2e/testcafe-devextreme/tests/dataGrid/common/filterRow/functional.ts:205 - The test uses
test.onlywhich will cause other tests in this file to be skipped during test execution. This should be changed totestbefore merging to ensure all tests run in CI.
anna-shakhova
force-pushed
the
26_1__T1312521
branch
from
0df1985 to
b0b94a7
Compare
anna-shakhova
force-pushed
the
26_1__T1312521
branch
from
b0b94a7 to
4ba0ff4
Compare
Alyar666
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.